Re: [SVN-MIGRATION] svn: SVNROOT/

[email protected] (Hannes Magnusson) Tue, 14 Jul 2009 08:45:41 +0200
Newsgroups php.cvs,svn.migration
Message-ID <[email protected]>
On Tue, Jul 14, 2009 at 08:38, Hannes
Magnusson<[email protected]> wrote:
> On Tue, Jul 14, 2009 at 01:40, Gwynne Raskind<[email protected]> wrote:
>> - =A0 =A0if ($username =3D=3D $commit_user) {
>> - =A0 =A0 =A0 =A0$from =3D imap_8bit("\"{$fullname}\" <{$username}@php.n=
et>");
>> + =A0 =A0if ($username =3D=3D=3D 'ladderalice') {
>> + =A0 =A0 =A0 =A0$saw_last_ISO =3D TRUE;
>> + =A0 =A0}
>> + =A0 =A0if ($username =3D=3D=3D $commit_user) {
>> + =A0 =A0 =A0 =A0if (!$saw_last_ISO) {
>> + =A0 =A0 =A0 =A0 =A0 =A0$fullname =3D iconv("ISO-8859-1", "UTF-8//TRANS=
LIT", $fullname);
>> + =A0 =A0 =A0 =A0}
>> + =A0 =A0 =A0 =A0$from =3D "\"{$fullname}\" <{$username}@php.net>";
>> =A0 =A0 =A0 =A0 break;
>> =A0 =A0 }
>> =A0}
>
> Huh? That makes no sense to me.
>
> You are probably looking for something along the lines of:
> if (!mb_check_encoding($fullname, "UTF-8")) {
> =A0$fullname =3D iconv("ISO-8859-1", "UTF-8", $fullname);
> }


And that seems to have broken commits from my gsoc student:

From: =3D?utf-8?Q?"Moacir=3D20de=3D20Oliveira=3D20Miranda=3D20J=3DC3=3DBAni=
or"=3D20<[email protected]>?=3D
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=3D"utf-8"
MIME-Version: 1.0
To: [email protected], [email protected]