Re: [PATCH] dm: change kzalloc to kcalloc

On 24/12/24 16:13, Ethan Carter Edwards wrote:
> Use 2-factor multiplication argument form kcalloc() instead
> of instead of the deprecated kzalloc() [1].

Thanks for the patch - Just note that kzalloc() is by no means
deprecated.

> 
> [1] https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
> Link: https://github.com/KSPP/linux/issues/162
> 
> Signed-off-by: Ethan Carter Edwards <[email protected]>

Reviewed-by: Gustavo A. R. Silva <[email protected]>

-Gustavo

> ---
>   drivers/md/dm-ps-io-affinity.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/dm-ps-io-affinity.c b/drivers/md/dm-ps-io-affinity.c
> index 461ee6b2044d..716807e511ee 100644
> --- a/drivers/md/dm-ps-io-affinity.c
> +++ b/drivers/md/dm-ps-io-affinity.c
> @@ -116,7 +116,7 @@ static int ioa_create(struct path_selector *ps, unsigned int argc, char **argv)
>   	if (!s)
>   		return -ENOMEM;
>   
> -	s->path_map = kzalloc(nr_cpu_ids * sizeof(struct path_info *),
> +	s->path_map = kcalloc(nr_cpu_ids, sizeof(struct path_info *),
>   			     GFP_KERNEL);
>   	if (!s->path_map)
>   		goto free_selector;