[PATCH] sched/topology: change kzalloc to kcalloc
Ethan Carter Edwards <[email protected]> Wed, 25 Dec 2024 00:11:55 +0000
| Newsgroups | com.openwall.lists.kernel-hardening,org.kernel.vger.linux-hardening,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <ieLySO0wXjkbKYOTqu2fRbPKXUdAB6xw5zDQedqQEpBKTD4t61myv42eN9b14T6nmoBd6lb45oK5_2rQ9mYKrNCTs76PrDVpLjk8CFf95E0=@ethancedwards.com> |
We are replacing any instances of kzalloc(size * count, ...) with kcalloc(count, size, ...) due to risk of overflow [1]. [1] https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded= -arithmetic-in-allocator-arguments Link: https://github.com/KSPP/linux/issues/162 Signed-off-by: Ethan Carter Edwards <[email protected]> --- kernel/sched/topology.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 9748a4c8d668..17eb12819563 100644 --- a/kernel/sched/topology.c +++ b/kernel/sched/topology.c @@ -1920,7 +1920,7 @@ void sched_init_numa(int offline_node) =09*/ =09sched_domains_numa_levels =3D 0; =20 -=09masks =3D kzalloc(sizeof(void *) * nr_levels, GFP_KERNEL); +=09masks =3D kcalloc(nr_levels, sizeof(void *), GFP_KERNEL); =09if (!masks) =09=09return; =20 @@ -1929,7 +1929,7 @@ void sched_init_numa(int offline_node) =09* CPUs of nodes that are that many hops away from us. =09*/ =09for (i =3D 0; i < nr_levels; i++) { -=09=09masks[i] =3D kzalloc(nr_node_ids * sizeof(void *), GFP_KERNEL); +=09=09masks[i] =3D kcalloc(nr_node_ids, sizeof(void *), GFP_KERNEL); =09=09if (!masks[i]) =09=09=09return; =20 --=20 2.47.1