[PATCH] wireguard: omit need_resched() before cond_resched()

Mikulas Patocka <[email protected]>
Newsgroups com.zx2c4.lists.wireguard,org.kernel.vger.netdev
Message-ID <[email protected]>
There's no need to call need_resched() because cond_resched() will do
nothing if need_resched() returns false.

Signed-off-by: Mikulas Patocka <[email protected]>

---
 drivers/net/wireguard/receive.c |    3 +--
 drivers/net/wireguard/send.c    |    6 ++----
 2 files changed, 3 insertions(+), 6 deletions(-)

Index: linux-2.6/drivers/net/wireguard/receive.c
===================================================================
--- linux-2.6.orig/drivers/net/wireguard/receive.c	2024-03-30 20:07:03.000000000 +0100
+++ linux-2.6/drivers/net/wireguard/receive.c	2025-07-14 19:09:52.000000000 +0200
@@ -501,8 +501,7 @@ void wg_packet_decrypt_worker(struct wor
 			likely(decrypt_packet(skb, PACKET_CB(skb)->keypair)) ?
 				PACKET_STATE_CRYPTED : PACKET_STATE_DEAD;
 		wg_queue_enqueue_per_peer_rx(skb, state);
-		if (need_resched())
-			cond_resched();
+		cond_resched();
 	}
 }
 
Index: linux-2.6/drivers/net/wireguard/send.c
===================================================================
--- linux-2.6.orig/drivers/net/wireguard/send.c	2024-07-21 17:40:39.000000000 +0200
+++ linux-2.6/drivers/net/wireguard/send.c	2025-07-14 19:10:03.000000000 +0200
@@ -279,8 +279,7 @@ void wg_packet_tx_worker(struct work_str
 
 		wg_noise_keypair_put(keypair, false);
 		wg_peer_put(peer);
-		if (need_resched())
-			cond_resched();
+		cond_resched();
 	}
 }
 
@@ -303,8 +302,7 @@ void wg_packet_encrypt_worker(struct wor
 			}
 		}
 		wg_queue_enqueue_per_peer_tx(first, state);
-		if (need_resched())
-			cond_resched();
+		cond_resched();
 	}
 }
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.