Re: [PATCH net-next v4 04/11] tools: ynl-gen: refactor local vars for .attr_put() callers
Jakub Kicinski <[email protected]>
| Newsgroups | com.zx2c4.lists.wireguard,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On Sat, 13 Sep 2025 23:58:25 +0000 Asbjørn Sloth Tønnesen wrote: > Refactor the generation of local variables needed when building > requests, by moving the logic into the Type classes, and use the > same helper in all places where .attr_put() is called. > > If any attributes requests identical local_vars, then they will > be deduplicated, attributes are assumed to only use their local > variables transiently. Nope, this is not good enough. I prefer the obvious hack than a one-off member mixed into the object model.