Re: [PATCH RFC 22/35] dma-remap: drop nth_page() in dma_common_contiguous_remap()
Marek Szyprowski <[email protected]>
| Newsgroups | com.zx2c4.lists.wireguard,dev.linux.lists.iommu,dev.linux.lists.virtualization,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-riscv,org.kernel.vger.io-uring,org.kernel.vger.kvm,org.kernel.vger.linux-crypto,org.kernel.vger.linux-ide,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kernel.vger.linux-mips,org.kernel.vger.linux-mmc,org.kernel.vger.linux-s390,org.kernel.vger.linux-scsi,org.kernel.vger.netdev,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On 21.08.2025 22:06, David Hildenbrand wrote: > dma_common_contiguous_remap() is used to remap an "allocated contiguous > region". Within a single allocation, there is no need to use nth_page() > anymore. > > Neither the buddy, nor hugetlb, nor CMA will hand out problematic page > ranges. > > Cc: Marek Szyprowski <[email protected]> > Cc: Robin Murphy <[email protected]> > Signed-off-by: David Hildenbrand <[email protected]> Acked-by: Marek Szyprowski <[email protected]> > --- > kernel/dma/remap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/dma/remap.c b/kernel/dma/remap.c > index 9e2afad1c6152..b7c1c0c92d0c8 100644 > --- a/kernel/dma/remap.c > +++ b/kernel/dma/remap.c > @@ -49,7 +49,7 @@ void *dma_common_contiguous_remap(struct page *page, size_t size, > if (!pages) > return NULL; > for (i = 0; i < count; i++) > - pages[i] = nth_page(page, i); > + pages[i] = page++; > vaddr = vmap(pages, count, VM_DMA_COHERENT, prot); > kvfree(pages); > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland