Re: [PATCH v1 15/36] fs: hugetlbfs: remove nth_page() usage within folio in adjust_range_hwpoison()
Lorenzo Stoakes <[email protected]>
| Newsgroups | com.zx2c4.lists.wireguard,dev.linux.lists.iommu,dev.linux.lists.virtualization,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.infradead.lists.linux-arm-kernel,org.infradead.lists.linux-riscv,org.kernel.vger.io-uring,org.kernel.vger.kvm,org.kernel.vger.linux-crypto,org.kernel.vger.linux-ide,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kernel.vger.linux-mips,org.kernel.vger.linux-mmc,org.kernel.vger.linux-s390,org.kernel.vger.linux-scsi,org.kernel.vger.netdev,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On Thu, Aug 28, 2025 at 12:01:19AM +0200, David Hildenbrand wrote: > The nth_page() is not really required anymore, so let's remove it. > While at it, cleanup and simplify the code a bit. Hm Not sure which bit is the cleanup? Was there meant to be more here or? > > Signed-off-by: David Hildenbrand <[email protected]> LGTM, so: Reviewed-by: Lorenzo Stoakes <[email protected]> > --- > fs/hugetlbfs/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index 34d496a2b7de6..c5a46d10afaa0 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -217,7 +217,7 @@ static size_t adjust_range_hwpoison(struct folio *folio, size_t offset, > break; > offset += n; > if (offset == PAGE_SIZE) { > - page = nth_page(page, 1); > + page++; LOL at that diff. Great! > offset = 0; > } > } > -- > 2.50.1 >