Re: [PATCH v1 31/36] vfio/pci: drop nth_page() usage within SG entry
Alex Williamson <[email protected]> Thu, 28 Aug 2025 12:52:51 -0600
| Newsgroups | com.zx2c4.lists.wireguard,dev.linux.lists.iommu,dev.linux.lists.virtualization,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.infradead.lists.linux-riscv,org.kernel.vger.io-uring,org.kernel.vger.kvm,org.kernel.vger.linux-crypto,org.kernel.vger.linux-ide,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kernel.vger.linux-mips,org.kernel.vger.linux-mmc,org.kernel.vger.linux-s390,org.kernel.vger.linux-scsi,org.kernel.vger.netdev,org.kvack.linux-mm |
|---|---|
| Organization | Red Hat |
| Message-ID | <[email protected]> |
On Thu, 28 Aug 2025 00:01:35 +0200 David Hildenbrand <[email protected]> wrote: > It's no longer required to use nth_page() when iterating pages within a > single SG entry, so let's drop the nth_page() usage. > > Cc: Brett Creeley <[email protected]> > Cc: Jason Gunthorpe <[email protected]> > Cc: Yishai Hadas <[email protected]> > Cc: Shameer Kolothum <[email protected]> > Cc: Kevin Tian <[email protected]> > Cc: Alex Williamson <[email protected]> > Signed-off-by: David Hildenbrand <[email protected]> > --- > drivers/vfio/pci/pds/lm.c | 3 +-- > drivers/vfio/pci/virtio/migrate.c | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/vfio/pci/pds/lm.c b/drivers/vfio/pci/pds/lm.c > index f2673d395236a..4d70c833fa32e 100644 > --- a/drivers/vfio/pci/pds/lm.c > +++ b/drivers/vfio/pci/pds/lm.c > @@ -151,8 +151,7 @@ static struct page *pds_vfio_get_file_page(struct pds_vfio_lm_file *lm_file, > lm_file->last_offset_sg = sg; > lm_file->sg_last_entry += i; > lm_file->last_offset = cur_offset; > - return nth_page(sg_page(sg), > - (offset - cur_offset) / PAGE_SIZE); > + return sg_page(sg) + (offset - cur_offset) / PAGE_SIZE; > } > cur_offset += sg->length; > } > diff --git a/drivers/vfio/pci/virtio/migrate.c b/drivers/vfio/pci/virtio/migrate.c > index ba92bb4e9af94..7dd0ac866461d 100644 > --- a/drivers/vfio/pci/virtio/migrate.c > +++ b/drivers/vfio/pci/virtio/migrate.c > @@ -53,8 +53,7 @@ virtiovf_get_migration_page(struct virtiovf_data_buffer *buf, > buf->last_offset_sg = sg; > buf->sg_last_entry += i; > buf->last_offset = cur_offset; > - return nth_page(sg_page(sg), > - (offset - cur_offset) / PAGE_SIZE); > + return sg_page(sg) + (offset - cur_offset) / PAGE_SIZE; > } > cur_offset += sg->length; > } Reviewed-by: Alex Williamson <[email protected]>