Re: [PATCH] wg-quick: fix darwin MTU detection
Florian Uekermann <[email protected]> Tue, 5 May 2026 18:47:33 +0200
| Newsgroups | com.zx2c4.lists.wireguard |
|---|---|
| Message-ID | <[email protected]> |
Hi Jason, Thanks for following up. On 04/05/2026 13:55, Jason A. Donenfeld wrote: > If you're submitting a patch with your name on it, please do the > research to make sure it's correct! Otherwise, what you're submitting is > more of a bug report than a patch. Please treat this as a bug report. That's why I added the disclaimer. I tried a number of different things before sending this patch with ack, because I wasn't able to get the bug report through the filter (mailing list, mod-mail) or noticed (IRC, Github) after many failed attempts to report it. Some avenue for drive-by bug reports may be beneficial (maybe Github issues). I had given up on reporting this until your reply. Anyway, happy you saw this now. > Should this be changed for the other invocations of `netstat -nr -f ...` > in the code? It's a bit confusing because in del_route(), it looks like > the first invocation (for inet) is aware that it's the 6th parameter, > while the second invocation (for inet6) seems to stick with this > presumption that it's the 4th. So what's going on here? I also suspect del_route needs to be adjusted too, but I have no idea what's going on here. > I'd like to get to the bottom of this before applying this patch. When > you submit a v2, please include your explanation as part of the commit > message. Sorry, I'm not very familiar with the Apple ecosystem and can't figure out what exactly happened or should be done here with the necessary confidence. Please just take this as a bug report. Best regards, Florian