Re: [PATCH] arm: dts: rk3568-nanopi-r5s: drop eMMC HS400 modes from the U-Boot FDT
Quentin Schulz <[email protected]> Mon, 20 Jul 2026 13:07:04 +0200
| Newsgroups | de.denx.lists.u-boot |
|---|---|
| Message-ID | <[email protected]> |
Hi Peter, On 7/20/26 9:59 AM, Peter Robinson wrote: > On Mon, 20 Jul 2026 at 02:59, Tianling Shen <[email protected]> wrote: >> >> Hi Daniel, >> >> On Sun, Jul 19, 2026 at 9:53 AM Daniel Golle <[email protected]> wrote: >>> >>> U-Boot passes its control FDT to Linux, so the &sdhci override adding >>> mmc-hs400-1_8v and mmc-hs400-enhanced-strobe reached the kernel, which >>> unlike U-Boot actually drives those modes and then failed on the eMMC. >>> Keep HS200, which works, and leave HS400 out. Affects the R5C too, which >>> includes this dtsi. >>> >>> Fixes: 0ef326b5e92e ("rockchip: rk3568: Add support for FriendlyARM NanoPi R5S") >>> Signed-off-by: Daniel Golle <[email protected]> >>> --- >>> arch/arm/dts/rk3568-nanopi-r5s-u-boot.dtsi | 2 -- >>> 1 file changed, 2 deletions(-) >>> >>> diff --git a/arch/arm/dts/rk3568-nanopi-r5s-u-boot.dtsi b/arch/arm/dts/rk3568-nanopi-r5s-u-boot.dtsi >>> index 64c43374c04..7e0b2ba02e4 100644 >>> --- a/arch/arm/dts/rk3568-nanopi-r5s-u-boot.dtsi >>> +++ b/arch/arm/dts/rk3568-nanopi-r5s-u-boot.dtsi >>> @@ -15,8 +15,6 @@ >>> &sdhci { >>> cap-mmc-highspeed; >>> mmc-hs200-1_8v; >>> - mmc-hs400-1_8v; >>> - mmc-hs400-enhanced-strobe; >>> pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastrobe>; >>> }; >> >> The whole sdhci node can be removed from u-boot.dtsi since these props >> are already included by upstream dts. > > I've already sent a patch to do exactly this, it was on my list to > chase up for this cycle: > https://lists.denx.de/pipermail/u-boot/2025-December/605369.html > I can merge that patch once my question there gets an answer :) Cheers, Quentin