Re: [PATCH] arm: dts: rk3568-nanopi-r5s: drop eMMC HS400 modes from the U-Boot FDT
Peter Robinson <[email protected]> Mon, 20 Jul 2026 13:22:23 +0100
| Newsgroups | de.denx.lists.u-boot |
|---|---|
| Message-ID | <CALeDE9OUMdos6fX3dJR+7E1X9uT8MV-FCPqWbNz7KuQU8gH6jA@mail.gmail.com> |
On Mon, 20 Jul 2026 at 12:07, Quentin Schulz <[email protected]> wro= te: > > Hi Peter, > > On 7/20/26 9:59 AM, Peter Robinson wrote: > > On Mon, 20 Jul 2026 at 02:59, Tianling Shen <[email protected]> wrote: > >> > >> Hi Daniel, > >> > >> On Sun, Jul 19, 2026 at 9:53=E2=80=AFAM Daniel Golle <daniel@makrotopi= a.org> wrote: > >>> > >>> U-Boot passes its control FDT to Linux, so the &sdhci override adding > >>> mmc-hs400-1_8v and mmc-hs400-enhanced-strobe reached the kernel, whic= h > >>> unlike U-Boot actually drives those modes and then failed on the eMMC= . > >>> Keep HS200, which works, and leave HS400 out. Affects the R5C too, wh= ich > >>> includes this dtsi. > >>> > >>> Fixes: 0ef326b5e92e ("rockchip: rk3568: Add support for FriendlyARM N= anoPi R5S") > >>> Signed-off-by: Daniel Golle <[email protected]> > >>> --- > >>> arch/arm/dts/rk3568-nanopi-r5s-u-boot.dtsi | 2 -- > >>> 1 file changed, 2 deletions(-) > >>> > >>> diff --git a/arch/arm/dts/rk3568-nanopi-r5s-u-boot.dtsi b/arch/arm/dt= s/rk3568-nanopi-r5s-u-boot.dtsi > >>> index 64c43374c04..7e0b2ba02e4 100644 > >>> --- a/arch/arm/dts/rk3568-nanopi-r5s-u-boot.dtsi > >>> +++ b/arch/arm/dts/rk3568-nanopi-r5s-u-boot.dtsi > >>> @@ -15,8 +15,6 @@ > >>> &sdhci { > >>> cap-mmc-highspeed; > >>> mmc-hs200-1_8v; > >>> - mmc-hs400-1_8v; > >>> - mmc-hs400-enhanced-strobe; > >>> pinctrl-0 =3D <&emmc_bus8 &emmc_clk &emmc_cmd &emmc_datastro= be>; > >>> }; > >> > >> The whole sdhci node can be removed from u-boot.dtsi since these props > >> are already included by upstream dts. > > > > I've already sent a patch to do exactly this, it was on my list to > > chase up for this cycle: > > https://lists.denx.de/pipermail/u-boot/2025-December/605369.html > > > > I can merge that patch once my question there gets an answer :) Replied, apologies, I must have read it as a statement and not a question and as a result missed replying. P