Re: [PATCH] CI: install python-cryptography for world build

--BMpQicDrT/Uo/cOD
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 20, 2026 at 02:13:22PM +0100, Casey Connolly wrote:

> The mkmbn Python tool used for some Qualcomm platforms needs the
> cryptography module, make sure it's installed so the world build can
> succeed.
>=20
> Signed-off-by: Casey Connolly <[email protected]>
> ---
>  .azure-pipelines.yml | 2 +-
>  .gitlab-ci.yml       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/.azure-pipelines.yml b/.azure-pipelines.yml
> index 4417ef4e5a50..562c5747c9d3 100644
> --- a/.azure-pipelines.yml
> +++ b/.azure-pipelines.yml
> @@ -733,9 +733,9 @@ stages:
>            python3 -m venv /tmp/venv
>            . /tmp/venv/bin/activate
>            pip install -r tools/binman/requirements.txt \
>              -r tools/buildman/requirements.txt \
> -            setuptools
> +            setuptools cryptography
>            if [[ "${BUILDMAN}" !=3D "" ]]; then
>                ret=3D0;
>                tools/buildman/buildman -o /tmp -PEWM ${BUILDMAN} ${OVERRI=
DE} || ret=3D$?;
>                if [[ $ret -ne 0 ]]; then
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 245e422d72fa..eb13fde82b86 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -153,9 +153,9 @@ build all platforms in a single job:
>      - python3 -m venv /tmp/venv;
>        . /tmp/venv/bin/activate;
>        pip install -r tools/binman/requirements.txt
>          -r tools/buildman/requirements.txt
> -        setuptools
> +        setuptools cryptography
>      - ret=3D0;
>        git config --global --add safe.directory "${CI_PROJECT_DIR}";
>        ./tools/buildman/buildman -o /tmp -PEWM -x xtensa || ret=3D$?;
>        if [[ $ret -ne 0 ]]; then

Ugh. This shows (a) the CI pipelines had another place that should have
been installing scripts/dtc/pylibfdt/requirements.txt and (b) I don't
know if we should make either boards/qualcomm/requirements.txt or try
again with a top-level requirements.txt file. I believe before Heinrich
disliked that I was including other requirements.txt files in it. I
thought I had said something in reply, but it was a while ago.

--=20
Tom

--BMpQicDrT/Uo/cOD
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTzzqh0PWDgGS+bTHor4qD1Cr/kCgUCal4xWAAKCRAr4qD1Cr/k
CnOPAQD4HP1EPOx88v1Bb/VQQVjzh3n82KZ2Z7/FBfOZlso5/QD/bvsFGHgXpeMy
lvGF0575EyjTowT72t7UdN+e8fkHkgg=
=RmOd
-----END PGP SIGNATURE-----

--BMpQicDrT/Uo/cOD--