[Accel-config] Re: [PATCH v3] accel-config/libaccel-config: Add IAX support

On Wed, Nov 18, 2020 at 01:52:00PM -0800, Tony Luck <tony.luck(a)intel.com> wrote:
> On Wed, Nov 18, 2020 at 04:14:18PM -0500, ramesh.thomas(a)intel.com wrote:
> > From: Ramesh Thomas <ramesh.thomas(a)intel.com>
> >
> > Add Intel Analytics Accelerator support.
> >
> > Changes in v3:
> > - include v2 change in json object creation
> >
> > Changes in v2:
> > - block on fault is available for IAX
> >
> > Signed-off-by: Ramesh Thomas <ramesh.thomas(a)intel.com>
> > Signed-off-by: Dave Jiang <dave.jiang(a)intel.com>
> > ---
> >  accfg/config.c          | 10 ++++++++++
> >  accfg/lib/libaccfg.c    |  3 +++
> >  accfg/libaccel_config.h |  1 +
> >  accfg/list.c            | 31 +++++++++++++++++++------------
> >  util/json.c             |  6 ++++--
> >  5 files changed, 37 insertions(+), 14 deletions(-)
> 
> Ramesh,
> 
> Just a note to point out that the convention is to put the
> history information after the "---" line and before the diffstat.
> 
> This is because projects don't really want the history of each
> patch preserved in the GIT commit history for all time. The "git am"
> tool automatically stops saving the commit comment at the "---" line.
> 
> -Tony

Hi Tony,

Thanks for bringing that to my attention and also your feedbacks. I will
remove the history from the commit when I merge to the stable branch.

Regards,
Ramesh