[Accel-config] [PATCH 5/5] accel-config/test: Remove load/unload of kernel modules in test

ramesh.thomas at intel.com
Newsgroups dev.linux.lists.accel-config
Message-ID <[email protected]>
From: Ramesh Thomas <ramesh.thomas(a)intel.com>

Loading and unloading of kernel modules in test is unreliable due to
dependencies across multiple modules. It is also not necessary because
the test should be run only after necessary idxd kernel modules are
loaded.

Signed-off-by: Ramesh Thomas <ramesh.thomas(a)intel.com>
---
 test/libaccfg.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/test/libaccfg.c b/test/libaccfg.c
index 951985d..ce21fb3 100644
--- a/test/libaccfg.c
+++ b/test/libaccfg.c
@@ -1074,18 +1074,12 @@ static int idxd_kmod_init(struct kmod_ctx **ctx, struct kmod_module **mod,
 		return rc;
 	}
 	rc = kmod_module_get_initstate(*mdev_mod);
-	if (rc == -ENOENT)
-		rc = kmod_module_probe_insert_module(*mdev_mod, 0, NULL, NULL, NULL,
-				NULL);
 	if (rc < 0) {
 		kmod_module_unref(*mdev_mod);
 		*mdev_mod = NULL;
 		mdev_disabled = true;
 	}
 	rc = kmod_module_get_initstate(*mod);
-	if (rc == -ENOENT)
-		rc = kmod_module_probe_insert_module(*mod, 0, NULL, NULL, NULL,
-				NULL);
 	if (rc < 0) {
 		kmod_module_unref(*mod);
 		kmod_unref(*ctx);
@@ -1165,12 +1159,9 @@ int test_libaccfg(int loglevel, struct accfg_test *test,
 
 	test_cleanup(ctx);
 
-	if (mdev_mod) {
-		kmod_module_remove_module(mdev_mod, 0);
+	if (mdev_mod)
 		kmod_module_unref(mdev_mod);
-	}
-	kmod_module_remove_module(mod, 0);
-	kmod_module_probe_insert_module(mod, 0, NULL, NULL, NULL, NULL);
+
 	kmod_module_unref(mod);
 	kmod_unref(kmod_ctx);
 
-- 
2.26.3
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.