[Accel-config] Re: [PATCH v2] accel-config/test: Call uacce API to get wq file descriptor

Dave Jiang <dave.jiang at intel.com>
Newsgroups dev.linux.lists.accel-config
Message-ID <[email protected]>
On 4/5/2021 6:41 PM, ramesh.thomas(a)intel.com wrote:
> From: Ramesh Thomas <ramesh.thomas(a)intel.com>
>
> Char dev major/minor method of getting file descriptor is being replaced
> by uacce interface. Replace calls to char dev API with new API to open
> uacce device.
>
> Signed-off-by: Ramesh Thomas <ramesh.thomas(a)intel.com>


Reviewed-by: Dave Jiang <dave.jiang(a)intel.com>


> ---
> V2:
> Call the changed API name to get user device path
>
>   test/dsa.c | 18 +++++++-----------
>   1 file changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/test/dsa.c b/test/dsa.c
> index 602bfb8..65ce807 100644
> --- a/test/dsa.c
> +++ b/test/dsa.c
> @@ -69,19 +69,15 @@ struct dsa_context *dsa_init(void)
>   
>   static int dsa_setup_wq(struct dsa_context *ctx, struct accfg_wq *wq)
>   {
> -	struct accfg_device *dev;
> -	int major, minor;
> -	char path[1024];
> +	char path[PATH_MAX];
> +	int rc;
>   
> -	dev = accfg_wq_get_device(wq);
> -	major = accfg_device_get_cdev_major(dev);
> -	if (major < 0)
> -		return -ENODEV;
> -	minor = accfg_wq_get_cdev_minor(wq);
> -	if (minor < 0)
> -		return -ENODEV;
> +	rc = accfg_wq_get_user_dev_path(wq, path, PATH_MAX);
> +	if (rc) {
> +		fprintf(stderr, "Error getting uacce device path\n");
> +		return rc;
> +	}
>   
> -	sprintf(path, "/dev/char/%u:%u", major, minor);
>   	ctx->fd = open(path, O_RDWR);
>   	if (ctx->fd < 0) {
>   		perror("open");
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.