[Accel-config] Re: [PATCH v1 1/1] accel-config/test: set tokens_allowed 0 in profiles for better bandwidth

On 12/6/2021 8:00 PM, Tony Zhu wrote:
> According test tokens_allowed = 8, BW is limited to ~8 GBPS per WQ. Set
> 0 to remove the limitation.
>
> Signed-off-by: Tony Zhu <tony.zhu(a)intel.com>

LGTM

Reviewed-by: Dave Jiang <dave.jiang(a)intel.com>


> ---
>   contrib/configs/app_profile.conf     | 4 ++--
>   contrib/configs/os_profile.conf      | 2 +-
>   contrib/configs/profilenote.txt      | 4 ++++
>   contrib/configs/storage_profile.conf | 4 ++--
>   4 files changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/contrib/configs/app_profile.conf b/contrib/configs/app_profile.conf
> index a6a3b12..3aa16ac 100644
> --- a/contrib/configs/app_profile.conf
> +++ b/contrib/configs/app_profile.conf
> @@ -7,7 +7,7 @@
>           "dev":"group0.0",
>           "tokens_reserved":0,
>           "use_token_limit":0,
> -        "tokens_allowed":8,
> +        "tokens_allowed":0,
>           "grouped_workqueues":[
>             {
>               "dev":"wq0.0",
> @@ -34,7 +34,7 @@
>           "dev":"group0.1",
>           "tokens_reserved":0,
>           "use_token_limit":0,
> -        "tokens_allowed":8,
> +        "tokens_allowed":0,
>           "grouped_workqueues":[
>             {
>               "dev":"wq0.1",
> diff --git a/contrib/configs/os_profile.conf b/contrib/configs/os_profile.conf
> index 1ee721f..077ce58 100644
> --- a/contrib/configs/os_profile.conf
> +++ b/contrib/configs/os_profile.conf
> @@ -7,7 +7,7 @@
>           "dev":"group0.0",
>           "tokens_reserved":0,
>           "use_token_limit":0,
> -        "tokens_allowed":8,
> +        "tokens_allowed":0,
>           "grouped_workqueues":[
>             {
>               "dev":"wq0.0",
> diff --git a/contrib/configs/profilenote.txt b/contrib/configs/profilenote.txt
> index 6debc9a..1e3d1c7 100644
> --- a/contrib/configs/profilenote.txt
> +++ b/contrib/configs/profilenote.txt
> @@ -9,6 +9,7 @@ profile descriptions.
>               - max xfer size=2MB, max batch sz=32, bof=0
>               - priority 10
>               - threshold 15
> +	    - tokens_allowed 0
>   
>   2. app_profile.conf
>       Recommended dsa default application profile.
> @@ -17,6 +18,7 @@ profile descriptions.
>                 max xfer size=16KB, max batch sz=32, bof=0, threshold=6
>               - Grp2 - SWQ2(a)32qd, 1eng
>                 max xfer size=2MB, max batch sz=32, bof=0, threshold=28
> +	    - tokens_allowed 0
>               - Use group1 for smaller size ops with better latency characteristics
>   
>   3. net_profile.conf
> @@ -24,6 +26,7 @@ profile descriptions.
>       - 4 groups, each with 1 DWQ(a)32qd/1 eng per group
>               - Each DWQ has max xfer size=16KB
>   	    - DWQ threshold default 0
> +	    - tokens_allowed 0
>   
>   4. storage_profile.conf
>       Recommended dsa storage accel profile
> @@ -34,3 +37,4 @@ profile descriptions.
>                 for throughput ops
>               - targeting SPDK-like uses
>   	    - DWQ threshold default 0
> +	    - tokens_allowed 0
> diff --git a/contrib/configs/storage_profile.conf b/contrib/configs/storage_profile.conf
> index f301b4c..13f58c5 100644
> --- a/contrib/configs/storage_profile.conf
> +++ b/contrib/configs/storage_profile.conf
> @@ -7,7 +7,7 @@
>           "dev":"group0.0",
>           "tokens_reserved":0,
>           "use_token_limit":0,
> -        "tokens_allowed":8,
> +        "tokens_allowed":0,
>           "grouped_workqueues":[
>             {
>               "dev":"wq0.0",
> @@ -34,7 +34,7 @@
>           "dev":"group0.1",
>           "tokens_reserved":0,
>           "use_token_limit":0,
> -        "tokens_allowed":8,
> +        "tokens_allowed":0,
>           "grouped_workqueues":[
>             {
>               "dev":"wq0.1",