[Accel-config] Re: [PATCH 0/3] Change token attr to read buffer

On 12/16/2021 11:01 AM, Ramesh Thomas wrote:
> This change matches the driver change that changes bandwidth token sysfs
> attribute to read buffers. Creates new API for read buffers and
> deprecates existing ones for bw tokens. Generate warnings if
> configuration file contains token attributes. Config commands leave
> short option unchanged while renames long options to indicate read
> buffers. Internal implementation is changed to use read buffers and
> would fall back to bw token attributes if read buffer attribute is not
> found due to use of older drivers.
>
> Ramesh Thomas (3):
>    accel-config: Add support for new attributes related to read buffers
>    accel-config: Add deprecated attribute and warnings
>    accel-config: Update manpages to use "read buffer" instead of "token"

LGTM

Reviewed-by: Dave Jiang <dave.jiang(a)intel.com>

for the series.


>
>   .../accfg/accel-config-config-device.txt      | 10 +--
>   .../accfg/accel-config-config-group.txt       | 26 +++---
>   Documentation/accfg/accel-config-list.txt     | 28 +++---
>   accfg/config.c                                | 70 ++++++++++-----
>   accfg/config_attr.c                           | 66 +++++++-------
>   accfg/lib/libaccel-config.sym                 | 13 +++
>   accfg/lib/libaccfg.c                          | 90 ++++++++++++++-----
>   accfg/lib/private.h                           | 10 +--
>   accfg/libaccel_config.h                       | 48 +++++++---
>   accfg/list.c                                  | 12 +--
>   test/libaccfg.c                               | 52 +++++------
>   util/json.c                                   |  8 +-
>   12 files changed, 268 insertions(+), 165 deletions(-)
>