[Accel-config] Re: [PATCH v1 3/9] accel-config/test: add pattern2 to fill destination buffers

Dave Jiang <dave.jiang at intel.com> Fri, 11 Feb 2022 10:18:54 -0700
Newsgroups dev.linux.lists.accel-config
Message-ID <[email protected]>
On 2/11/2022 6:16 AM, Tony Zhu wrote:
> Use pattern to fill source buffers, use pattern2 to fill destination
> buffers.
Just a question. What is pattern 2 used for? Checking to see if it gets 
overwritten?
>
> Signed-off-by: Tony Zhu <tony.zhu(a)intel.com>
> ---
>   test/dsa.c | 7 +++----
>   test/dsa.h | 1 +
>   2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/test/dsa.c b/test/dsa.c
> index 7d5b396..f427664 100644
> --- a/test/dsa.c
> +++ b/test/dsa.c
> @@ -287,6 +287,7 @@ int init_task(struct task *tsk, int tflags, int opcode,
>   	dbg("initilizing single task %#lx\n", tsk);
>   
>   	tsk->pattern = 0x0123456789abcdef;
> +	tsk->pattern2 = 0xfedcba9876543210;
>   	tsk->opcode = opcode;
>   	tsk->test_flags = tflags;
>   	tsk->xfer_size = xfer_size;
> @@ -321,8 +322,7 @@ int init_task(struct task *tsk, int tflags, int opcode,
>   		tsk->dst1 = aligned_alloc(1 << 12, xfer_size);
>   		if (!tsk->dst1)
>   			return -ENOMEM;
> -		if (tflags & TEST_FLAGS_PREF)
> -			memset(tsk->dst1, 0, xfer_size);
> +		memset_pattern(tsk->dst1, tsk->pattern2, xfer_size);
>   	}
>   
>   	/* allocate memory: dst2*/
> @@ -332,8 +332,7 @@ int init_task(struct task *tsk, int tflags, int opcode,
>   		tsk->dst2 = aligned_alloc(1 << 12, xfer_size);
>   		if (!tsk->dst2)
>   			return -ENOMEM;
> -		if (tflags & TEST_FLAGS_PREF)
> -			memset(tsk->dst2, 0, xfer_size);
> +		memset_pattern(tsk->dst2, tsk->pattern2, xfer_size);
>   	}
>   
>   	dbg("Mem allocated: s1 %#lx s2 %#lx d1 %#lx d2 %#lx\n",
> diff --git a/test/dsa.h b/test/dsa.h
> index 0af226c..6363bbd 100644
> --- a/test/dsa.h
> +++ b/test/dsa.h
> @@ -59,6 +59,7 @@ struct task {
>   	void *dst2;
>   	void *delta1;
>   	uint64_t pattern;
> +	uint64_t pattern2;
>   	uint64_t xfer_size;
>   	uint32_t dflags;
>   	int test_flags;