[Accel-config] Re: [PATCH] accel-config: Skip writing driver_name attr if not present

On 3/28/2022 6:22 PM, Ramesh Thomas wrote:
> Older drivers do not create driver_name attr. Skip writing driver_name
> instead of failing if not present.
>
> Signed-off-by: Ramesh Thomas <ramesh.thomas(a)intel.com>
Reviewed-by: Dave Jiang <dave.jiang(a)intel.com>
> ---
>   accfg/lib/libaccfg.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/accfg/lib/libaccfg.c b/accfg/lib/libaccfg.c
> index b4a9725..6af5802 100644
> --- a/accfg/lib/libaccfg.c
> +++ b/accfg/lib/libaccfg.c
> @@ -2459,7 +2459,11 @@ ACCFG_EXPORT int accfg_wq_set_str_##field( \
>   			return -errno; \
>   		} \
>   	} \
> -	if (sysfs_write_attr(ctx, path, buf) < 0) { \
> +	rc = sysfs_write_attr(ctx, path, buf); \
> +	if (rc < 0) { \
> +		/* Silently skip attrs not supported by driver */ \
> +		if (rc == -ENOENT && !strcmp(#field, "driver_name")) \
> +			return 0; \
>   		err(ctx, "%s: write failed: %s\n", \
>   				accfg_wq_get_devname(wq), \
>   				strerror(errno)); \