[Accel-config] Re: [PATCH v1 1/1] accel-config/test: Fix description timeout calculation to overflow
Dave Jiang <dave.jiang at intel.com> Wed, 27 Apr 2022 18:48:48 -0700
| Newsgroups | dev.linux.lists.accel-config |
|---|---|
| Message-ID | <[email protected]> |
On 4/27/2022 6:31 PM, Tony Zhu wrote:
> Dsa_test application will fail when when utilizing memory sizes larger
> than 128MiB against multiple devices. The init of timeout should use
> the input msec_timeout.
>
> Signed-off-by: Tony Zhu <tony.zhu(a)intel.com>
Ken, you want your sign off added?
> ---
> test/accel_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/accel_test.c b/test/accel_test.c
> index 8487099..0468a00 100644
> --- a/test/accel_test.c
> +++ b/test/accel_test.c
> @@ -331,7 +331,7 @@ int acctest_wait_on_desc_timeout(struct completion_record *comp,
> j++;
> }
> } else {
> - unsigned long timeout = (ms_timeout * 1000000) * 3;
> + unsigned long timeout = (msec_timeout * 1000000ul) * 3;
Couple things. This looks like changed with the common code refactoring?
Has that merged by Ramesh? If not then maybe do the diff before that
code since we need to get this fix released. And then make sure the
refactoring take this change into account.
Also, did you compile test this? I don't see the var name ms_timeout
changed to msec_timeout.
> int r = 1;
> unsigned long t = 0;
>