[Accel-config] Re: [PATCH v1 0/2] replace token with read_buffer of config files
Dave Jiang <dave.jiang at intel.com> Thu, 08 Sep 2022 08:47:46 -0700
| Newsgroups | dev.linux.lists.accel-config |
|---|---|
| Message-ID | <[email protected]> |
--===============7838292863978004138== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 9/7/2022 6:56 PM, Zhu, Tony wrote: > Dave, > > I think the sample configs also need to be updated same as other conf= igs. > It will make confusing if the sample is not aligned with other config= s. Please submit additional patches and update. Thank you. > > Tony(zhu, xinzhan) > Cube:SHZ1-3W-279 > iNet:8821-5077 > > -----Original Message----- > From: Jiang, Dave <dave.jiang(a)intel.com> > Sent: Wednesday, September 7, 2022 10:55 PM > To: Zhu, Tony <tony.zhu(a)intel.com>; accel-config(a)lists.01.org; Thomas= , Ramesh <ramesh.thomas(a)intel.com>; Yu, Fenghua <fenghua.yu(a)intel.com> > Subject: Re: [Accel-config] [PATCH v1 0/2] replace token with read_buffer= of config files > > > On 9/6/2022 11:08 PM, Tony Zhu wrote: >> use_token_limit tokens_reserved tokens_allowed and token_limit will be >> replaced as use_read_buffer_limit read_buffers_reserved >> read_buffers_allowed and read_buffer_limit. >> All config files need to be updated. > LGTM. Reviewed-by: Dave Jiang <dave.jiang(a)intel.com> > > Tony do you know if the sample configs need update as well? > > >> Tony Zhu (2): >> accel-config/test: replace token with read_buffer of config files in >> contrib >> accel-config/test: replace token with read_buffer in test config >> files >> >> contrib/accel-config.conf.sample | 28 +++++++++++++++------------- >> contrib/configs/app_profile.conf | 14 +++++++------- >> contrib/configs/net_profile.conf | 26 +++++++++++++------------- >> contrib/configs/os_profile.conf | 8 ++++---- >> contrib/configs/profilenote.txt | 8 ++++---- >> contrib/configs/storage_profile.conf | 14 +++++++------- >> test/configs/2g2q_user_1.conf | 26 +++++++++++++------------- >> 7 files changed, 63 insertions(+), 61 deletions(-) >> --===============7838292863978004138==--