Re: [Accel-config] [PATCH v3 1/2] accel-config: Add defconfig.conf for default config

In a meeting today regarding the default config issue, we decided to do 
it a bit differently than simply loading a default config file. 
Accel-config would only configure user type WQs. It will scan all 
devices in sysfs for engines and WQs that are not enabled yet. They will 
be configured into a new group and enabled. The WQs would be configured 
as shared and the name would be set to indicate it is a default 
configuration.

Thanks for this patch. I would refer to this and other sample configs to 
set the default parameter values. My plan is to remove the kernel 
configurations and keep the user configurations as a template and 
internally load them into a json array that will be used to set the 
attributes of each device being configured.

On 5/12/2023 8:51 AM, Dave Jiang wrote:
> 
> 
> On 5/11/23 10:31 PM, Rex Zhang wrote:
>> A default configuration file is necessary. Add defconfig.conf
>> as the default config file. Configure 1 DSA and 1 IAX device,
>> 1 kernel wq and 1 user wq for either DSA or IAX by default.
>> The Kernel wq is configured in dedicated mode while the user
>> wq in shared mode.
>>
>> Signed-off-by: Rex Zhang <[email protected]>
> Reviewed-by: Dave Jiang <[email protected]>
>> ---
>>   contrib/configs/defconfig.conf | 109 +++++++++++++++++++++++++++++++++
>>   1 file changed, 109 insertions(+)
>>   create mode 100644 contrib/configs/defconfig.conf
>>
>> diff --git a/contrib/configs/defconfig.conf 
>> b/contrib/configs/defconfig.conf
>> new file mode 100644
>> index 0000000..2d27fc2
>> --- /dev/null
>> +++ b/contrib/configs/defconfig.conf
>> @@ -0,0 +1,109 @@
>> +[
>> +  {
>> +    "dev":"dsa0",
>> +    "read_buffer_limit":0,
>> +    "groups":[
>> +      {
>> +        "dev":"group0.0",
>> +        "grouped_workqueues":[
>> +          {
>> +            "dev":"wq0.0",
>> +            "mode":"dedicated",
>> +            "size":8,
>> +            "group_id":0,
>> +            "priority":10,
>> +            "block_on_fault":0,
>> +            "max_batch_size":32,
>> +            "max_transfer_size":16384,
>> +            "type":"kernel",
>> +            "driver_name":"dmaengine",
>> +            "name":"wq0.0",
>> +          }
>> +        ],
>> +        "grouped_engines":[
>> +          {
>> +            "dev":"engine0.0",
>> +            "group_id":0
>> +          }
>> +        ]
>> +      },
>> +      {
>> +        "dev":"group0.1",
>> +        "grouped_workqueues":[
>> +          {
>> +            "dev":"wq0.1",
>> +            "mode":"shared",
>> +            "size":32,
>> +            "group_id":1,
>> +            "priority":10,
>> +            "block_on_fault":1,
>> +            "max_batch_size":32,
>> +            "max_transfer_size":2097152,
>> +            "type":"user",
>> +            "driver_name":"user",
>> +            "name":"wq0.1",
>> +            "threshold":28
>> +          }
>> +        ],
>> +        "grouped_engines":[
>> +          {
>> +            "dev":"engine0.1",
>> +            "group_id":1
>> +          }
>> +        ]
>> +      }
>> +    ]
>> +  },
>> +  {
>> +    "dev":"iax1",
>> +    "groups":[
>> +      {
>> +        "dev":"group1.0",
>> +        "grouped_workqueues":[
>> +          {
>> +            "dev":"wq1.0",
>> +            "mode":"dedicated",
>> +            "size":8,
>> +            "group_id":2,
>> +            "priority":10,
>> +            "block_on_fault":0,
>> +            "max_transfer_size":16384,
>> +            "type":"kernel",
>> +            "driver_name":"crypto",
>> +            "name":"wq1.0",
>> +          }
>> +        ],
>> +        "grouped_engines":[
>> +          {
>> +            "dev":"engine1.0",
>> +            "group_id":2
>> +          }
>> +        ]
>> +      },
>> +      {
>> +        "dev":"group1.1",
>> +        "grouped_workqueues":[
>> +          {
>> +            "dev":"wq1.1",
>> +            "mode":"shared",
>> +            "size":32,
>> +            "group_id":3,
>> +            "priority":10,
>> +            "block_on_fault":1,
>> +            "max_transfer_size":4194304,
>> +            "type":"user",
>> +            "driver_name":"user",
>> +            "name":"wq1.1",
>> +            "threshold":28
>> +          }
>> +        ],
>> +        "grouped_engines":[
>> +          {
>> +            "dev":"engine1.1",
>> +            "group_id":3
>> +          }
>> +        ]
>> +      }
>> +    ]
>> +  }
>> +]