Re: [PATCH 04/12] i3c: master: Support ACPI enumeration

On Tue, Mar 24, 2026 at 10:52:15PM +0530, Akhil R wrote:
> On Tue, 24 Mar 2026 09:43:27 +0100, Alexandre Belloni wrote:
> 
> ...
> 
> >> #include <linux/acpi.h> is added in PATCH 03/12. The functions' prototypes
> >> are present in acpi.h. I think the bot checked this patch individually,
> >> or did I miss something?
> >> 
> > 
> > #include <acpi/acpi_bus.h> is behind an #ifdef in acpi.h and your code
> > is not.
> 
> Thanks for pointing Alexandre and Guenter. I also noticed that we do not
> have stub functions for a few of the acpi_* functions in #else.
> 
> Looks like I will have to guard calls to these functions under
> #ifdef CONFIG_ACPI.

Alternatively it might make sense to add the stubs in a separate patch.
I don't know if they were purposefully left out or nobody's ever run
into the lack of these before.

Thierry

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmnDv/0ACgkQ3SOs138+
s6G9+g/+LuZP8mpHvXnaAevACtJDkWGEheqiXMIkXddWa0UJAazqokRhVFFxWNqL
KiHVB2TKCmyKj+ID/r0+YQyLpsAJE5Vc0I6oqP70QyFtUpBsvtYESRHg7Kmg36Kl
YTj1voyogdqTiAfPjwI0T3b1cmUoJpB6H2qTG9sZYbbJJ1G8fySmR8JvNHeDkjjf
4QYzhRp+HWbT7uNjc9mOUo/e2bVCGcIrT+usgwGPXq2g9i2Lvfduk5pp1669JbZ9
SCxaYdNcq3aZMQ0G52cMSuOp/70zEpPhFOE0s1EHkVFge5pNoqTkymLAj5Pg1Wk8
PT+bzWX+W+ViFhV//9lQ3Yx0JXQo5ZlIjqGl8aG0rCrA3qg+PgYj9vRHuFv8QoPF
FeEWPSS+QzZPPuF/SktUCTI8/fgexXGg9IN9j1nalAEu218EqtIdw4pH566Zt0BN
FlUqJ0ibFMgyxEzO4JMdueb8Wd4TMsKpdxQZ2INphJmyEHoIMEq17JlOs7d0fDGa
CWdnSDBlNosjKX8oaUZj6rTrmcvDc1un6i7PWBjHbjN/zqfuAZQXiZkRp4Q3DJ4V
g/3464luFjrpt5XkJD3RsiFM+UuT53RKL7vIa0odHNBtt0SOZC4wrx9zhrKCQEh3
6ksFj9We1bqQm7sOxHFtFsfmvI/fnuc1w67aIdJCRevb++v3DCU=
=nNsB
-----END PGP SIGNATURE-----