Re: [PATCH 03/24] ASoC: codecs: arizona-jack: Use guard() cleanup helpers

Charles Keepax <[email protected]> Fri, 26 Jun 2026 13:06:01 +0100

Newsgroups	dev.linux.lists.asahi,dev.linux.lists.chrome-platform,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound
Message-ID	<[email protected]>

On Fri, Jun 26, 2026 at 01:13:08PM +0700, [email protected] wrote:
> From: bui duc phuc <[email protected]>
> 
> Clean up the code using guard() helpers for mutex locking
> and PM runtime management.
> No functional change intended.
> 
> Signed-off-by: bui duc phuc <[email protected]>
> ---
> @@ -1057,7 +1051,14 @@ static irqreturn_t arizona_jackdet(int irq, void *data)
>  					   msecs_to_jiffies(micd_timeout));
>  		}
>  
> -		goto out;
> +		/* Clear trig_sts to make sure DCVDD is not forced up */
> +		regmap_write(arizona->regmap, ARIZONA_AOD_WKUP_AND_TRIG,
> +			     ARIZONA_MICD_CLAMP_FALL_TRIG_STS |
> +			     ARIZONA_MICD_CLAMP_RISE_TRIG_STS |
> +			     ARIZONA_JD1_FALL_TRIG_STS |
> +			     ARIZONA_JD1_RISE_TRIG_STS);
> +
> +		return IRQ_HANDLED;

Like cs42l43 I am really not sure about this duplicated code
block.

Thanks,
Charles