Re: [PATCH 1/3] dt-bindings: soc: apple: Add bindings for apple PMGR misc controls
Krzysztof Kozlowski <[email protected]>
| Newsgroups | dev.linux.lists.asahi,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260703-spotted-silver-nyala-b39ec4@quoll> |
On Thu, Jul 02, 2026 at 02:06:26PM +0200, Sasha Finkelstein wrote: > Certain Apple SoCs include additional PMGR power states that are > controlled via a different "misc" control block. On existing SoCs, this > includes the fabric and memory controller state. > > Signed-off-by: Sasha Finkelstein <[email protected]> Just a nit on top of Conor's review, if there is a new version: A nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23 Best regards, Krzysztof