Re: [PATCH] cpufreq: apple-soc: Calculate frequency as a 64-bit value
Sasha Finkelstein <[email protected]>
| Newsgroups | dev.linux.lists.asahi,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-pm |
|---|---|
| Message-ID | <[email protected]> |
On Jul 3, 2026, at 22:52, David Laight <[email protected]> wrote: > > If it matters you need to fix it for 32bit builds as well. > It is pretty much really wrong to use 'unsigned long' for frequencies. > IMHO the should either be 32bit or 64bit. This module has a 64BIT dep, and is not applicable to 32-bit devices. In addition, the calculation is passed to dev_pm_opp_find_freq_floor, which is core code and takes an unsigned long.