Re: [PATCH v2 4/7] ASoC: apple: mca: Support FEs being clock consumers
James Calligeros <[email protected]>
| Newsgroups | dev.linux.lists.asahi,org.kernel.vger.linux-kernel,org.kernel.vger.linux-sound |
|---|---|
| Message-ID | <[email protected]> |
Hi Josh, On Monday, 29 June 2026 11:19:27 pm Australian Eastern Standard Time Joshua Peisach wrote: > On Sun Jun 28, 2026 at 7:42 AM EDT, James Calligeros wrote: > > + writel_relaxed(port + 6 + 1, > > + cl->base + REG_SYNCGEN_MCLK_SEL); > > Where does the "6 + 1" come from, and should it have its own #define? This actually only ever gets set to 0b111 (port = 0), and trying to set it to anything else breaks the machines which consume VISENSE data from the connected codecs. I will just replace this with a static value for v3, which seems to work on all the machines we currently support downstream. > -Josh James