Re: [PATCH v2 2/3] usb: typec: tipd: Factor out i2c specifics

Heikki Krogerus <[email protected]>
Newsgroups dev.linux.lists.asahi,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel,org.kernel.vger.linux-usb
Message-ID <[email protected]>
On Wed, Aug 05, 2026 at 01:57:18PM +0200, Sasha Finkelstein wrote:
> On Aug 5, 2026, at 13:47, Heikki Krogerus <[email protected]> wrote:
> >> 
> >> -static const struct regmap_config tps6598x_regmap_config = {
> >> +const struct regmap_config tps6598x_regmap_config = {
> >> .reg_bits = 8,
> >> .val_bits = 8,
> >> .max_register = 0x7F,
> >> };
> >> +EXPORT_SYMBOL_GPL(tps6598x_regmap_config);
> > 
> > Don't export that. Just move it to i2c.c
> 
> I use this one in spmi.c too, the regmap configuration is the same,
> just the backend is different

Ah, sorry I missed that.

Thanks,

-- 
heikki
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.