Re: [PATCH v4 0/3] nvmem: migrate to const void * in reg_write
Andy Shevchenko <[email protected]>
| Newsgroups | dev.linux.lists.asahi,dev.linux.lists.imx,org.infradead.lists.linux-amlogic,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.kernel.vger.rust-for-linux |
|---|---|
| Organization | Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo |
| Message-ID | <[email protected]> |
On Sun, Jul 26, 2026 at 03:17:18PM +0200, Link Mauve wrote: > This callback used to take a mutable void * for no reason, which causes > the compiler to be unaware that the val buffer should never be modified > by the callback. > > This was found while drafting the nvmem-provider Rust abstraction. > > Thanks to the guidance of Andy Shevchenko, this now introduces a new > callback and deprecates the existing one, with the goal of renaming the > new one into the old one once no user remains in the kernel. LGTM now, FWIW, Reviewed-by: Andy Shevchenko <[email protected]> But I think you also need to provide a road map of finishing this job (the best is to provide a continuation in some of yours public Git trees to point out). -- With Best Regards, Andy Shevchenko