Re: [PATCH 1/3] dt-bindings: reset: Add Apple SoC CIO reset

Sven Peter <[email protected]>
Newsgroups dev.linux.lists.asahi,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel
Message-ID <[email protected]>

On 8/10/26 18:02, Conor Dooley wrote:
> On Sun, Aug 09, 2026 at 02:16:02PM +0200, Sven Peter wrote:
>> The CIO (USB4/Thunderbolt) blocks on Apple Silicon SoCs have a reset
>> inside the power manager that has to be deasserted before their
>> co-processor can be booted. On t8103 each port comes with a dedicated
>> register page, represented as a standalone node. On t600x a single
>> register shared by all ports of a die is located in the middle of the
>> PMGR MMIO region instead, represented as a sub-node of the PMGR syscon.
>>
>> Signed-off-by: Sven Peter <[email protected]>
> Fix the sashiko complaint and then
> Reviewed-by: Conor Dooley <[email protected]>
> pw-bot: not-applicable
>
>> +  - |
>> +    power-management@28e080000 {
>> +        compatible = "apple,t6000-pmgr", "apple,pmgr", "syscon", "simple-mfd";
>> +        reg = <0x8e080000 0x1c000>;
>> +        #address-cells = <1>;
>> +        #size-cells = <1>;
>> +
>> +        reset-controller@1a034 {
>> +            compatible = "apple,t6000-cio-reset";
>> +            reg = <0x1a034 0x4>;
>> +            #reset-cells = <1>;
>> +        };
>> +    };
> Probably the fix is actually moving this to the parent device bnding.

Thanks for the review, I've moved the example to the parent binding 
where I just had to add the reset-controller node itself and could drop 
all the stuff around it.


Thanks,


Sven
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.