Re: [RFC 3/4] wifi: nl80211: strict checking attributes for NL80211_CMD_SET_BSS

Johannes Berg <[email protected]>
Newsgroups dev.linux.lists.brcm80211,org.kernel.vger.linux-wireless
Message-ID <[email protected]>
On Wed, 2025-06-04 at 10:55 +0200, Arend van Spriel wrote:
> 
> +	if (strict && (changed & ~rdev->wiphy.bss_param_support))
> +		return -EINVAL;
> +

>  	return rdev_change_bss(rdev, dev, &params);

You probably also need

	changed &= rdev->wiphy.bss_param_support;
	if (!changed)
		return 0;

(a) to force drivers to actually list the bits they want to see, and
(b) to not call the (partially now-removed) driver calls for "no change"
(or no change it cares about)

johannes
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.