Re: [PATCH wireless-next v4] wifi: brcmfmac: fix EXTSAE WPA3 connection failure due to AUTH TX failure

On 7/23/2025 12:59 PM, Gokul Sivakumar wrote:
> From: Ting-Ying Li <[email protected]>
> 
> For WPA3-SAE Connection in EXTSAE mode, the userspace daemon is allowed to
> generate the SAE Auth frames. The driver uses the "mgmt_frame" FW IOVAR to
> transmit this MGMT frame.
> 
> Before sending the IOVAR, the Driver is incorrectly treating the channel
> number read from the FW as a frequency value and again attempts to convert
> this into a channel number using ieee80211_frequency_to_channel().
> 
> This added an invalid channel number as part of the IOVAR request to the FW
> And some FW which strictly expects a valid channel would return BAD_CHAN
> error, while failing to transmit the driver requested SAE Auth MGMT frame.
> 
> Fix this in the CYW vendor specific MGMT TX cfg80211 ops handler, by not
> treating the channel number read from the FW as frequency value and skip
> the attempt to convert it again into a channel number.
> 
> Also fix this in the generic MGMT TX cfg80211 ops handler.
> 
> Fixes: c2ff8cad6423 ("brcm80211: make mgmt_tx in brcmfmac accept a NULL channel")
> Fixes: 66f909308a7c ("wifi: brcmfmac: cyw: support external SAE authentication in station mode")

Acked-by: Arend van Spriel <[email protected]>> 
Signed-off-by: Ting-Ying Li <[email protected]>
> Signed-off-by: Gokul Sivakumar <[email protected]>
> ---

[...]

>   .../broadcom/brcm80211/brcmfmac/cfg80211.c    | 30 ++++++++++++-------
>   .../broadcom/brcm80211/brcmfmac/cyw/core.c    | 26 +++++++++-------
>   2 files changed, 35 insertions(+), 21 deletions(-)