Re: [PATCH wireless-next v3] wifi: brcmfmac: fix 43752 SDIO FWVID incorrectly labelled as Cypress (CYW)

Arend van Spriel <[email protected]> Thu, 24 Jul 2025 12:53:37 +0200
Newsgroups dev.linux.lists.brcm80211,org.kernel.vger.linux-wireless
Message-ID <[email protected]>
On 7/24/2025 12:11 PM, Gokul Sivakumar wrote:
> Cypress(Infineon) is not the vendor for this 43752 SDIO WLAN chip, and so
> has not officially released any firmware binary for it. It is incorrect to
> maintain this WLAN chip with firmware vendor ID as "CYW". So relabel the
> chip's firmware Vendor ID as "WCC" as suggested by the maintainer.
> 
> Fixes: d2587c57ffd8 ("brcmfmac: add 43752 SDIO ids and initialization")
> Fixes: f74f1ec22dc2 ("wifi: brcmfmac: add support for Cypress firmware api")

Acked-by: Arend van Spriel <[email protected]>

> Signed-off-by: Gokul Sivakumar <[email protected]>
> ---
> 
> v3:
>   * Rephrased the subject to indicate that the incorrect firmware Vendor ID
>     (FWVID) of 43752 SDIO is fixed by this patch.
> 
> v2:
>   * Relabelled the 43752-SDIO chip from CYW to WCC instead of dropping the
>     support for this chip as suggested by Arend.
> 
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 2 +-
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c   | 4 ++--
>   drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c   | 8 ++++----
>   .../net/wireless/broadcom/brcm80211/include/brcm_hw_ids.h | 1 -
>   include/linux/mmc/sdio_ids.h                              | 2 +-
>   5 files changed, 8 insertions(+), 9 deletions(-)