Re: [PATCH] wifi: brcmsmac: phy: Remove unreachable error handling code
Arend van Spriel <[email protected]> Sun, 1 Feb 2026 10:37:31 +0100
| Newsgroups | dev.linux.lists.brcm80211,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
On 31/01/2026 18:23, Ingyu Jang wrote:
> wlc_phy_txpwr_srom_read_lcnphy() in wlc_phy_attach_lcnphy() always
> returns true, making the error handling code unreachable. Change the
> function's return type to void and remove the dead code, similar to
> the cleanup done for wlc_phy_txpwr_srom_read_nphy() in commit
> 47f0e32ffe4e ("wifi: brcmsmac: phy: Remove unreachable code").
Acked-by: Arend van Spriel <[email protected]>
> Signed-off-by: Ingyu Jang <[email protected]>
> ---
> .../wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)