Re: [PATCH] wifi: brcmsmac: phy_lcn: Remove dead code in wlc_lcnphy_radio_2064_channel_tune_4313()
Arend van Spriel <[email protected]> Fri, 17 Apr 2026 21:18:05 +0200
| Newsgroups | dev.linux.lists.brcm80211,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
On 03/04/2026 21:33, Chelsy Ratnawat wrote: > The variable rfpll_doubler is initialized to 0 and then unconditionally > set to 1 on the very next line, making the subsequent check for > !rfpll_doubler always evaluate to false. This results in logically > dead code that has never been executed. > > Remove the unused variable, the unreachable conditional branch, and > simplify the fpfd calculation to directly use the PLL doubler values. Acked-by: Arend van Spriel <[email protected]> > Signed-off-by: Chelsy Ratnawat <[email protected]> > --- > .../broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-)