Re: [PATCH] brcmfmac-cyw: clean up PMKID and cookie code
Arend van Spriel <[email protected]> Mon, 6 Jul 2026 21:06:12 +0200
| Newsgroups | dev.linux.lists.brcm80211,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 3 Jul 2026 17:39:51 -0500, Bogdan Nicolae wrote: > Avoid setting packet_id to cookie, which is always 0. Instead, use an > increasing atomic counter. Avoids mismatches of completion events later > in brcmf_notify_mgmt_tx_status, where packet_id != vif->mgmt_tx_id is > checked. > > Also, zero out auth_status on initialization. Otherwise, garbage will > leak from the stack to the firmware (when bssid is less than 32 bytes > and/or when params->pmkid is set). Then, pass the params->pmkid to the > firmware (without it, the firmware caches a garbage PMKID on successful > authentication and denies a subsequent association request that includes > the PMKID). > > Signed-off-by: Bogdan Nicolae <[email protected]> The patch failed to apply because it had line-wrapped diff lines. Please resend. git format-patch and git send-email are your friend (well, can be). Also, the subject line is missing the "wifi:" prefix. It should read: wifi: brcmfmac: cyw: clean up PMKID and cookie code Regards, Arend