Re: [PATCH] wifi: brcmfmac: cyw: clean up PMKID and cookie code
Bogdan Nicolae <[email protected]> Mon, 20 Jul 2026 16:30:45 -0500
| Newsgroups | dev.linux.lists.brcm80211,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <CA+ORkNQcUjZ7ufoR5ULN8UDTzxXccFcmD8=rYe=UWVV3-M15Ug@mail.gmail.com> |
Arend, Sounds good. Do you prefer two patches in a single email or two separate emails? Best, Bogdan On Mon, Jul 20, 2026 at 2:49 PM Arend van Spriel <[email protected]> wrote: > > On Tue, 14 Jul 2026, [email protected] wrote: > > > [PATCH] wifi: brcmfmac: cyw: clean up PMKID and cookie code > > The code itself is correct, but there are process issues that need to be > fixed before I can accept this: > > 1. This is a resubmission of the patch sent on 2026-07-09 [1]. A > resubmission must carry a version tag: the subject line should read > "[PATCH v2] wifi: brcmfmac: ..." not "[PATCH] wifi: brcmfmac: ...". > > 2. A v2 submission must include a "Changes in v2:" section below the --- > line documenting what changed from v1. > > 3. The From: address ([email protected]) does not match the > Signed-off-by address ([email protected]). Please use a > consistent address or add a second Signed-off-by for the sending > address. > > 4. The patch addresses two independent issues: fixing the packet_id in > brcmf_cyw_mgmt_tx() (SAE auth frame TX) and fixing the zero-init and > PMKID copy in brcmf_cyw_external_auth() (auth completion). Please > split these into two separate patches. > > Please send a v2 addressing these points. > > [1] https://lore.kernel.org/linux-wireless/[email protected]/ > > Regards, > Arend