Re: [PATCH v2] wifi: brcmfmac: cyw: set a unique cookie for mgmt tx

Bogdan Nicolae <[email protected]> Sun, 26 Jul 2026 14:21:17 -0500

Newsgroups	dev.linux.lists.brcm80211,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless
Message-ID	<CA+ORkNTq5Wn079=D_W6J+k1kbJtL+A1mfDU1furVsB9j=sa_qg@mail.gmail.com>

Sure, it sounds good. Thanks Arend.

Bogdan

On Sun, Jul 26, 2026 at 2:21=E2=80=AFPM Arend van Spriel
<[email protected]> wrote:
>
> On 25/07/2026 03:44, Bogdan Nicolae wrote:
> > Set cookie using an increasing atomic counter. Avoids mismatches of com=
pletion
> > events later in brcmf_notify_mgmt_tx_status, where packet_id !=3D vif->=
mgmt_tx_id
> > is checked.
>
> Thanks for the split. I increased the scope and been looking in the
> cookie usage in the wireless subsystem. So I have a series lined up to
> change the cookie to an input parameter and have cfg80211 hand out the
> cookie value (it already has cfg80211_assign_cookie() function). This
> will also cover zero cookie fix here. So I would suggest to drop this
> patch and only let the PMKID patch go in.
>
> Regards,
> Arend