Re: [PATCH -next v2 00/12] wifi: cfg80211: consolidate cookie assignment for async ops
Johannes Berg <[email protected]> Tue, 28 Jul 2026 17:39:33 +0200
| Newsgroups | dev.linux.lists.brcm80211,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
On Tue, 2026-07-28 at 16:45 +0200, Arend van Spriel wrote: > NL80211_ATTR_COOKIE is a userspace-visible u64 that correlates an async > nl80211 operation with its completion event. Three cfg80211 ops currently > delegate cookie generation to the driver: remain_on_channel, mgmt_tx, and > probe_peer. This produces inconsistent strategies across drivers: some us= e > an incrementing counter, some use get_random_u32(), some use a CID cast t= o > u64, and brcmfmac's mgmt_tx always assigned zero - which is arguably brok= en > since cfg80211 treats zero as an invalid cookie. [snip] Looks good to me, but I just finished merging for the day ;) I'll let it soak for a while, and driver maintainers should have a chance to review it as well, of course. We're in no hurry anyway... Thanks! :) johannes