Re: [PATCH v4 0/8] wifi: brcm80211: performance and stability fixes

On Fri, 31 Jul 2026 16:06:17 +0000, Shivesh <[email protected]> wrote:
> This series fixes several performance bottlenecks and correctness
> issues in both brcmfmac (PCIe/SDIO) and brcmsmac drivers.

Two blockers need to be fixed before any of this can be applied:

- 2/8: num++ was dropped from the subframe-parse loop. cnt is always 0
  on return, so rd->seq_num += cnt - 1 underflows to 255 (u8) on every
  successful glom receive, corrupting sequence-number tracking for all
  subsequent packets.

- 4/8: pmksa->fils_cache_id does not exist in struct cfg80211_pmksa;
  the correct field name is cache_id so this does not compile.

Beyond the blockers, please split the series into separate submissions:
1. Stability and correctness fixes (3/8, 5/8 TX-stall fix, 6/8 Fixes
   tagged part)
2. Performance improvements (1/8, 2/8, 5/8, 6/8 performance parts)
3. New functionality and comment-only patches (4/8 PMKID_V2,7/8, 8/8)

This makes it easier dealing with fixes that should go to stable trees.
For the stability series you can add Cc: [email protected] and a
Fixes: tag in the commit message.

Regarding patch 1/8: the patch also fixes a race where a ring state
changes RING_OPEN->RING_CLOSING while blocked causes a permanent
netif queue stop. The fix relies on the atomic counter so keeping them
together is fine, but this change is primarily a potential bug fix so
rephrase the subject, e.g. "fix blocked-ring race permanently stopping queue"

Finally, some of the commit messages seem to use LLM lingo so if there
was a coding assistent used please add an Assisted-by tag as required by
Documentation/process/coding-assistants.rst.

Regards,
Arend