Re: [PATCH] wifi: brcmfmac: Fix memory leak in brcmf_sdio_read_control()

Johannes Berg <[email protected]> Sun, 02 Aug 2026 18:41:32 +0200

Newsgroups	dev.linux.lists.brcm80211,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless,org.kernel.vger.stable
Message-ID	<[email protected]>

On Sun, 2026-08-02 at 10:38 +0200, Arend van Spriel wrote:
> On Wed, 22 Jul 2026 16:37:12 +0530, Abdun Nihaal <[email protected]> =
wrote:
> > The memory allocated for buf is not freed in some of the error paths in
> > brcmf_sdio_read_control(). Fix that by adding vfree() calls.
> >=20
> > Fixes: dd43a01c5cdb ("brcmfmac: use dynamically allocated control frame=
 buffer")
> > Cc: [email protected]
> > Signed-off-by: Abdun Nihaal <[email protected]>
> > ---
> > Compile tested only. Issue found using static analysis.
> >=20
> >  drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 3 +++
> >  1 file changed, 3 insertions(+)
>=20
> To be applied to wireless tree.

I'm going to put this into wireless-next, at this point (-rc6) this just
doesn't cut it, the commit message makes it sound purely theoretical.

johannes