Re: [PATCH] Fix memory leak in brcmf_get_module_param
Arend Van Spriel <[email protected]>
| Newsgroups | dev.linux.lists.brcm80211,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
On March 30, 2025 12:09:04 PM Arend Van Spriel <[email protected]> wrote: > On March 30, 2025 11:35:41 AM Abdun Nihaal <[email protected]> wrote: > >> The memory allocated for settings is not freed when brcmf_of_probe >> fails. Fix that by freeing settings before returning in error path. >> >> Fixes: 0ff0843310b7 ("wifi: brcmfmac: Add optional lpo clock enable support") > > Good catch. Thanks for the fix. The patch is fine, but a minor procedural nit that I should mention. The subject of patches for brcmfmac should have prefix "wifi: brcmfmac:" as shown in the Fixes: line. Hopefully Kalle can take care of that. Regards, Arend > > Acked-by: Arend van Spriel <[email protected]> >> Signed-off-by: Abdun Nihaal <[email protected]> >> --- >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-)