[PATCH RESEND] brcmfmac: Add an error log for brcmf_sdiod_ramrw()
Wentao Liang <[email protected]>
| Newsgroups | dev.linux.lists.brcm80211,org.kernel.vger.linux-kernel,org.kernel.vger.linux-wireless |
|---|---|
| Message-ID | <[email protected]> |
The function brcmf_sdio_buscore_activate() calls the function brcmf_sdiod_ramrw(), but does not check its return value. Log the error message to prevent silent failure if the function fails. Signed-off-by: Wentao Liang <[email protected]> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c index b1727f35217b..dd683c2582fb 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c @@ -3898,8 +3898,9 @@ static void brcmf_sdio_buscore_activate(void *ctx, struct brcmf_chip *chip, if (rstvec) /* Write reset vector to address 0 */ - brcmf_sdiod_ramrw(sdiodev, true, 0, (void *)&rstvec, - sizeof(rstvec)); + if (brcmf_sdiod_ramrw(sdiodev, true, 0, (void *)&rstvec, + sizeof(rstvec)) < 0) + brcmf_err("Fail to reset vector\n"); } static u32 brcmf_sdio_buscore_read32(void *ctx, u32 addr) -- 2.42.0.windows.2