Re: [PATCH wireless-next 4/4] wifi: brcmfmac: Fix structure size for WPA3 external SAE

On 4/24/2025 9:42 PM, Arend van Spriel wrote:
> From: Ting-Ying Li <[email protected]>
> 
> Add pmkid parameter in "brcmf_auth_req_status_le" structure to
> align the buffer size defined in firmware "wl_auth_req_status"
> structure.
> 
> Signed-off-by: Ting-Ying Li <[email protected]>

Hi Johannes,

checkpatch issued a warning about From: and SoB: difference, but how to 
resolve it. Both emails are stale so it does not matter, but I lean 
towards using the infineon email address as that is likely the most 
recent identity used given the company history. Please advice.

> [arend: adapted path to apply to per-vendor variant]
> Tested-by: James Prestwood <[email protected]>
> Signed-off-by: Arend van Spriel <[email protected]>
> ---
>   .../net/wireless/broadcom/brcm80211/brcmfmac/cyw/fwil_types.h    | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/fwil_types.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/fwil_types.h
> index 18129adb5dc2..1cbe66526d82 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/fwil_types.h
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cyw/fwil_types.h
> @@ -54,6 +54,7 @@ struct brcmf_auth_req_status_le {
>   	u8 peer_mac[ETH_ALEN];
>   	__le32 ssid_len;
>   	u8 ssid[IEEE80211_MAX_SSID_LEN];
> +	u8 pmkid[WLAN_PMKID_LEN];

Sure like the wifibot checks. Do run checkpatch and compile test for 
every patch before sending it out, but no kerneldoc. Will need to add 
kerneldoc for this struct field.

Regards,
Arend

>   };
>   
>   /**