Re: [PATCH wireless-next 4/4] wifi: brcmfmac: Fix structure size for WPA3 external SAE

On Fri, 2025-04-25 at 09:57 +0200, Arend van Spriel wrote:
> On 4/24/2025 9:42 PM, Arend van Spriel wrote:
> > From: Ting-Ying Li <[email protected]>
> > 
> > Add pmkid parameter in "brcmf_auth_req_status_le" structure to
> > align the buffer size defined in firmware "wl_auth_req_status"
> > structure.
> > 
> > Signed-off-by: Ting-Ying Li <[email protected]>
> 
> Hi Johannes,
> 
> checkpatch issued a warning about From: and SoB: difference, but how to 
> resolve it. Both emails are stale so it does not matter, but I lean 
> towards using the infineon email address as that is likely the most 
> recent identity used given the company history. Please advice.

I think you should probably keep whatever they used when they posted it.

> > +	u8 pmkid[WLAN_PMKID_LEN];
> 
> Sure like the wifibot checks. Do run checkpatch and compile test for 
> every patch before sending it out, but no kerneldoc. Will need to add 
> kerneldoc for this struct field.

Thanks :)

johannes