Re: [PATCH net v3] net: neigh: Reallocate headroom if necessary in neigh_hh_bridge()

Lorenzo Bianconi <[email protected]> Thu, 14 May 2026 16:24:18 +0200

Newsgroups	dev.linux.lists.bridge,org.kernel.vger.netdev,org.kernel.vger.netfilter-devel
Message-ID	<agXbEs03zO48f10r@lore-desk>

On May 14, Florian Westphal wrote:
> Lorenzo Bianconi <[email protected]> wrote:
> > > Personally I would use 'goto free_skb' after releasing the neighbour, to
> > > be consistent with the other paths that free the packet.
> > 
> > ack, I do not have a strong opinion about it, but in this case we would need to
> > even move "ret" since the current codebase always returns 0. What do you prefer?
> 
> I think It can return 0 unconditionally, there are no code paths in
> that function where skb doesn't disappear (ownership change or freed),
> and its prerouting so there is no use for an error code either.

ack, I will fix it in v4.

Regards,
Lorenzo

signature.asc (application/pgp-signature, 228 B)