Re: [PATCH net v2 2/2] vxlan: fix reading neigh ha

Nikolay Aleksandrov <[email protected]> writes:

> Currently arp/neigh_reduce read neigh ha directly which can lead to
> partial reads while the neigh is being updated. Use neigh_ha_snapshot to
> take a stable snapshot of the address similar to route_shortcircuit which
> already does the right thing.
>
> Fixes: e4f67addf158 ("add DOVE extensions for VXLAN")
> Fixes: f564f45c4518 ("vxlan: add ipv6 proxy support")
> Signed-off-by: Nikolay Aleksandrov <[email protected]>

Reviewed-by: Petr Machata <[email protected]>

> @@ -1935,7 +1938,8 @@ static int arp_reduce(struct net_device *dev, struct sk_buff *skb, __be32 vni)
>  
>  #if IS_ENABLED(CONFIG_IPV6)
>  static struct sk_buff *vxlan_na_create(struct sk_buff *request,
> -	struct neighbour *n, bool isrouter)
> +				       struct neighbour *n, u8 *ha,

(Likewise, I think this could be const u8 *ha.)

> +				       bool isrouter)
>  {
>  	struct net_device *dev = request->dev;
>  	struct sk_buff *reply;