Re: [PATCH v1 1/2] hwmon: cros_ec: Drop unused assignment of platform_device_id driver data

Thomas Weißschuh <[email protected]>
Newsgroups dev.linux.lists.chrome-platform,org.kernel.vger.linux-hwmon,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On 2026-05-27 17:15:52+0200, Uwe Kleine-König (The Capable Hub) wrote:
> The driver explicitly set the .driver_data member of struct
> platform_device_id to zero without relying on that value. Drop this
> unused assignments.
> 
> While touching this array unify spacing and 

> use named initializers for .name.

Not sure why this is better.

> Signed-off-by: Uwe Kleine-König (The Capable Hub) <[email protected]>

... but it doesn't really matter, so:
Acked-by: Thomas Weißschuh <[email protected]>

> ---
>  drivers/hwmon/cros_ec_hwmon.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/cros_ec_hwmon.c b/drivers/hwmon/cros_ec_hwmon.c
> index 7c308b0a4b9e..f6cf254395a8 100644
> --- a/drivers/hwmon/cros_ec_hwmon.c
> +++ b/drivers/hwmon/cros_ec_hwmon.c
> @@ -654,8 +654,8 @@ static int cros_ec_hwmon_resume(struct platform_device *pdev)
>  }
>  
>  static const struct platform_device_id cros_ec_hwmon_id[] = {
> -	{ DRV_NAME, 0 },
> -	{}
> +	{ .name = DRV_NAME },
> +	{ }
>  };
>  MODULE_DEVICE_TABLE(platform, cros_ec_hwmon_id);
>  
> -- 
> 2.47.3
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.