Re: [PATCH 10/83] ASoC: amd: use .auto_selectable_formats

"Mukunda,Vijendar" <[email protected]>
Newsgroups dev.linux.lists.chrome-platform,dev.linux.lists.imx,dev.linux.lists.spacemit,org.infradead.lists.linux-riscv,org.kernel.vger.linux-mips,org.kernel.vger.linux-renesas-soc,org.kernel.vger.linux-sound
Message-ID <[email protected]>

On 5/26/26 07:32, Kuninori Morimoto wrote:
> We can use .auto_selectable_formats. Let's adds it.
>
> Signed-off-by: Kuninori Morimoto <[email protected]>
Reviewed-by: Vijendar Mukunda <[email protected]>
> ---
>   sound/soc/amd/acp/acp-i2s.c       | 6 ++++++
>   sound/soc/amd/raven/acp3x-i2s.c   | 6 ++++++
>   sound/soc/amd/vangogh/acp5x-i2s.c | 6 ++++++
>   3 files changed, 18 insertions(+)
>
> diff --git a/sound/soc/amd/acp/acp-i2s.c b/sound/soc/amd/acp/acp-i2s.c
> index 283a674c7e2c3..bb58a9d34993b 100644
> --- a/sound/soc/amd/acp/acp-i2s.c
> +++ b/sound/soc/amd/acp/acp-i2s.c
> @@ -686,6 +686,10 @@ static int acp_i2s_startup(struct snd_pcm_substream *substream, struct snd_soc_d
>   	return 0;
>   }
>   
> +static const u64 acp_i2s_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_DSP_A;
> +
>   const struct snd_soc_dai_ops asoc_acp_cpu_dai_ops = {
>   	.startup	= acp_i2s_startup,
>   	.hw_params	= acp_i2s_hwparams,
> @@ -693,6 +697,8 @@ const struct snd_soc_dai_ops asoc_acp_cpu_dai_ops = {
>   	.trigger	= acp_i2s_trigger,
>   	.set_fmt	= acp_i2s_set_fmt,
>   	.set_tdm_slot	= acp_i2s_set_tdm_slot,
> +	.auto_selectable_formats	= &acp_i2s_selectable_formats,
> +	.num_auto_selectable_formats	= 1,
>   };
>   EXPORT_SYMBOL_NS_GPL(asoc_acp_cpu_dai_ops, "SND_SOC_ACP_COMMON");
>   
> diff --git a/sound/soc/amd/raven/acp3x-i2s.c b/sound/soc/amd/raven/acp3x-i2s.c
> index 352485dd98b14..b0147e88ba54c 100644
> --- a/sound/soc/amd/raven/acp3x-i2s.c
> +++ b/sound/soc/amd/raven/acp3x-i2s.c
> @@ -250,11 +250,17 @@ static int acp3x_i2s_trigger(struct snd_pcm_substream *substream,
>   	return ret;
>   }
>   
> +static const u64 acp3x_i2s_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_DSP_A;
> +
>   static const struct snd_soc_dai_ops acp3x_i2s_dai_ops = {
>   	.hw_params = acp3x_i2s_hwparams,
>   	.trigger = acp3x_i2s_trigger,
>   	.set_fmt = acp3x_i2s_set_fmt,
>   	.set_tdm_slot = acp3x_i2s_set_tdm_slot,
> +	.auto_selectable_formats = &acp3x_i2s_selectable_formats,
> +	.num_auto_selectable_formats = 1,
>   };
>   
>   static const struct snd_soc_component_driver acp3x_dai_component = {
> diff --git a/sound/soc/amd/vangogh/acp5x-i2s.c b/sound/soc/amd/vangogh/acp5x-i2s.c
> index bf719f6286174..dbfb87e2fe929 100644
> --- a/sound/soc/amd/vangogh/acp5x-i2s.c
> +++ b/sound/soc/amd/vangogh/acp5x-i2s.c
> @@ -337,11 +337,17 @@ static int acp5x_i2s_trigger(struct snd_pcm_substream *substream,
>   	return ret;
>   }
>   
> +static const u64 acp5x_i2s_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_DSP_A;
> +
>   static const struct snd_soc_dai_ops acp5x_i2s_dai_ops = {
>   	.hw_params = acp5x_i2s_hwparams,
>   	.trigger = acp5x_i2s_trigger,
>   	.set_fmt = acp5x_i2s_set_fmt,
>   	.set_tdm_slot = acp5x_i2s_set_tdm_slot,
> +	.auto_selectable_formats = &acp5x_i2s_selectable_formats,
> +	.num_auto_selectable_formats = 1,
>   };
>   
>   static const struct snd_soc_component_driver acp5x_dai_component = {
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.