[PATCH v1] watchdog: Use named initializers for platform_device_id arrays
Uwe Kleine-König (The Capable Hub) <[email protected]>
| Newsgroups | dev.linux.lists.chrome-platform,org.kernel.vger.linux-kernel,org.kernel.vger.linux-watchdog |
|---|---|
| Message-ID | <22bc09d0c9c8dfe75a205b0a9ccc98ccfba1de10.1781622532.git.u.kleine-koenig@baylibre.com> |
Named initializers are better readable and more robust to changes of the struct definition. This robustness is relevant for a planned change to struct platform_device_id replacing .driver_data by an anonymous union. For one driver drop the unused assignment to .driver_data instead. While touching these arrays unify spacing and usage of commas. There is no effect on the compiled arrays. Signed-off-by: Uwe Kleine-König (The Capable Hub) <[email protected]> --- Hello, this is similar in spirit as the i2c patches merged during the current merge window: c574bdb52409 ("watchdog: ziirave_wdt: Use named initializers for struct i2c_device_id") 54c726fbb533 ("watchdog: sc1200: Drop unused assignment of pnp_device_id driver data") but for platform_device_id. Best regards Uwe drivers/watchdog/cros_ec_wdt.c | 4 ++-- drivers/watchdog/max63xx_wdt.c | 14 +++++++------- drivers/watchdog/max77620_wdt.c | 6 +++--- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/watchdog/cros_ec_wdt.c b/drivers/watchdog/cros_ec_wdt.c index 9ffe7f505645..180784e92f2f 100644 --- a/drivers/watchdog/cros_ec_wdt.c +++ b/drivers/watchdog/cros_ec_wdt.c @@ -179,8 +179,8 @@ static int __maybe_unused cros_ec_wdt_resume(struct platform_device *pdev) } static const struct platform_device_id cros_ec_wdt_id[] = { - { DRV_NAME, 0 }, - {} + { .name = DRV_NAME }, + { } }; static struct platform_driver cros_ec_wdt_driver = { diff --git a/drivers/watchdog/max63xx_wdt.c b/drivers/watchdog/max63xx_wdt.c index 21935f9620e4..a9db6118fdfa 100644 --- a/drivers/watchdog/max63xx_wdt.c +++ b/drivers/watchdog/max63xx_wdt.c @@ -246,13 +246,13 @@ static int max63xx_wdt_probe(struct platform_device *pdev) } static const struct platform_device_id max63xx_id_table[] = { - { "max6369_wdt", (kernel_ulong_t)max6369_table, }, - { "max6370_wdt", (kernel_ulong_t)max6369_table, }, - { "max6371_wdt", (kernel_ulong_t)max6371_table, }, - { "max6372_wdt", (kernel_ulong_t)max6371_table, }, - { "max6373_wdt", (kernel_ulong_t)max6373_table, }, - { "max6374_wdt", (kernel_ulong_t)max6373_table, }, - { }, + { .name = "max6369_wdt", .driver_data = (kernel_ulong_t)max6369_table }, + { .name = "max6370_wdt", .driver_data = (kernel_ulong_t)max6369_table }, + { .name = "max6371_wdt", .driver_data = (kernel_ulong_t)max6371_table }, + { .name = "max6372_wdt", .driver_data = (kernel_ulong_t)max6371_table }, + { .name = "max6373_wdt", .driver_data = (kernel_ulong_t)max6373_table }, + { .name = "max6374_wdt", .driver_data = (kernel_ulong_t)max6373_table }, + { } }; MODULE_DEVICE_TABLE(platform, max63xx_id_table); diff --git a/drivers/watchdog/max77620_wdt.c b/drivers/watchdog/max77620_wdt.c index d3ced783a5f4..5fa891818e8d 100644 --- a/drivers/watchdog/max77620_wdt.c +++ b/drivers/watchdog/max77620_wdt.c @@ -236,9 +236,9 @@ static int max77620_wdt_probe(struct platform_device *pdev) } static const struct platform_device_id max77620_wdt_devtype[] = { - { "max77620-watchdog", (kernel_ulong_t)&max77620_wdt_data }, - { "max77714-watchdog", (kernel_ulong_t)&max77714_wdt_data }, - { }, + { .name = "max77620-watchdog", .driver_data = (kernel_ulong_t)&max77620_wdt_data }, + { .name = "max77714-watchdog", .driver_data = (kernel_ulong_t)&max77714_wdt_data }, + { } }; MODULE_DEVICE_TABLE(platform, max77620_wdt_devtype); base-commit: 4fa3f5fabb30bf00d7475d5a33459ea83d639bf9 -- 2.47.3